fix: signature order check#7016
Draft
brice-stacks wants to merge 3 commits intostacks-network:developfrom
Draft
Conversation
The last_index variable in verify_signer_signatures was only updated on the first loop iteration (inside an else branch), so subsequent signatures were checked against the first signer's index rather than the previous one. This allowed out-of-order sequences like [0, 2, 1] to pass validation. Move the assignment outside the conditional so it updates every iteration, and add a regression test.
Contributor
|
@brice-stacks This fixes #6907. |
Pull Request Test Coverage Report for Build 23526303949Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
federico-stacks
left a comment
There was a problem hiding this comment.
lgtm!
just a small question about the test configuration
federico-stacks
approved these changes
Mar 25, 2026
Contributor
Author
|
NOTE: Don't merge this until issue of old blocks is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last_index variable in verify_signer_signatures was only updated on the first loop iteration (inside an else branch), so subsequent signatures were checked against the first signer's index rather than the previous one. This allowed out-of-order sequences like [0, 2, 1] to pass validation. Move the assignment outside the conditional so it updates every iteration, and add a regression test.
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo