feat: add 'ci_skip' test tag to bitcoin-tests.yml to handle both docker rate limit and rpc test double run#7056
Merged
simone-stacks merged 5 commits intostacks-network:developfrom Apr 2, 2026
Conversation
Pull Request Test Coverage Report for Build 23865270369Details
💛 - Coveralls |
wileyj
approved these changes
Mar 30, 2026
simone-stacks
approved these changes
Apr 1, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that we are intermittently hitting Docker Hub rate limits when pulling images during CI runs
(see https://github.com/stacks-network/stacks-core/actions/runs/23514194002/job/68450961455?pr=6999)
According to GitHub’s official documentation and prior discussion #6927 (comment) these limits should not apply when
Suspected root cause
The issue appears to stem from how Docker images are pulled in certain jobs.
In the failing cases, images are pulled indirectly via the
testcontainerscrate (i.e., from within Rust code), rather than being explicitly pulled by the GitHub Actions runner itself. This differs from workflows likebitcoin-rpc-tests.yml, where images are pre-pulled in a dedicated step:stacks-core/.github/workflows/bitcoin-rpc-tests.yml
Lines 63 to 64 in 7a9774e
Because of this, the pulls performed by
testcontainersmay not benefit from the special configuration or exemptions applied to GitHub-hosted runners (at least this is my hope 😄 )Changes in this PR
To explore and mitigate this issue, this PR introduces the following:
ci_skiptest tag, allowing selective exclusion from default CI runsbitcoin-rpc-tests.ymlworkflow (which includes explicit image pre-pulling). This also avoid double runs of these tests both as dedicated workflow and as integration tests (an already known fact we wanted to address).Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo