More pox_5_make_reward_set#7064
Merged
hstove-stacks merged 1 commit intostacks-network:pox-5-integrationfrom Apr 3, 2026
Merged
More pox_5_make_reward_set#7064hstove-stacks merged 1 commit intostacks-network:pox-5-integrationfrom
pox_5_make_reward_set#7064hstove-stacks merged 1 commit intostacks-network:pox-5-integrationfrom
Conversation
…l units and proptests
hstove-stacks
merged commit 55acec6
into
stacks-network:pox-5-integration
2 checks passed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds geometric weighted means for D and adds some assertions around the fixed point arithmetic.
This also includes some initial unit tests and proptests.
I suspect that to really get good test coverage of this method (both tighter property tests and units), we'll need to break it into some smaller units, and test those.