Regenerated package-lock#12
Merged
mbwatson merged 5 commits intostagecc:mainfrom Mar 13, 2026
Merged
Conversation
mbwatson
approved these changes
Mar 11, 2026
Member
mbwatson
left a comment
mbwatson
left a comment
There was a problem hiding this comment.
looks good. builds fine for me.
suejinkim20
approved these changes
Mar 12, 2026
Collaborator
suejinkim20
left a comment
suejinkim20
left a comment
There was a problem hiding this comment.
👍🏼 works for me as well!
mbwatson
requested changes
Mar 12, 2026
Member
mbwatson
left a comment
mbwatson
left a comment
There was a problem hiding this comment.
I think we'd benefit from a short note in the README, something like:
Always use
npm cito install dependencies locally. Only usenpm install <package>when adding/removing a dependency, and commit the updatedpackage-lock.json. Running barenpm installcan cause platform-specific drift in the lock file.
maybe documenting this convention prevents future headaches. what do you think?
mbwatson
approved these changes
Mar 13, 2026
Member
mbwatson
left a comment
mbwatson
left a comment
There was a problem hiding this comment.
looks good! the new build check seems good, and the documentation will be helpful moving forward. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated the
package-lock.jsonfile to ensure that there's no errors while running it locally on Mac systems.