Skip to content

Add support for IPv6 hostnames in addrparse #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staktrace merged 1 commit into from
May 14, 2026
+41 −1
Merged

Add support for IPv6 hostnames in addrparse #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion src/addrparse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ fn addrparse_inner(
// Technically not valid, but occurs in real-world corpus, so handle it gracefully
state = AddrParseState::Initial;
addr = None;
} else if c == ':' {
} else if c == ':' && !addr.as_ref().map_or(false, |s| s.contains('@')) {
if in_group {
return Err(MailParseError::Generic(
"Found unexpected nested group",
Expand Down Expand Up @@ -1101,4 +1101,44 @@ mod tests {
])
);
}

#[test]
fn parse_ip_hostnames() {
assert_eq!(
addrparse("<test@example.org>").unwrap(),
MailAddrList(vec![MailAddr::Single(
SingleInfo::new(None, "test@example.org".to_string()).unwrap()
)])
);
assert_eq!(
addrparse("<test@[192.0.2.0]>").unwrap(),
MailAddrList(vec![MailAddr::Single(
SingleInfo::new(None, "test@[192.0.2.0]".to_string()).unwrap()
)])
);
assert_eq!(
addrparse("<test@[IPv6:2001:db8::1]>").unwrap(),
MailAddrList(vec![MailAddr::Single(
SingleInfo::new(None, "test@[IPv6:2001:db8::1]".to_string()).unwrap()
)])
);
assert_eq!(
addrparse("test@example.org").unwrap(),
MailAddrList(vec![MailAddr::Single(
SingleInfo::new(None, "test@example.org".to_string()).unwrap()
)])
);
assert_eq!(
addrparse("test@[192.0.2.0]").unwrap(),
MailAddrList(vec![MailAddr::Single(
SingleInfo::new(None, "test@[192.0.2.0]".to_string()).unwrap()
)])
);
assert_eq!(
addrparse("test@[IPv6:2001:db8::1]").unwrap(),
MailAddrList(vec![MailAddr::Single(
SingleInfo::new(None, "test@[IPv6:2001:db8::1]".to_string()).unwrap()
)])
);
}
}
Loading