Skip to content

Update laplace signatures to have hessian_block_size before covariance function#1599

Merged
SteveBronder merged 4 commits intomasterfrom
laplace-signature-tweaks
Mar 4, 2026
Merged

Update laplace signatures to have hessian_block_size before covariance function#1599
SteveBronder merged 4 commits intomasterfrom
laplace-signature-tweaks

Conversation

@WardBrian
Copy link
Member

See stan-dev/math#3286 (comment)

As per usual with these laplace functions, most of the diff is in the error messages and tests.

Also adds the generate_laplace_options helpers and restricts integrate_1d inside laplace (stan-dev/math#3280)

Submission Checklist

Release notes

Updated signatures of the embedded laplace approximation functions.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.31%. Comparing base (ae477a5) to head (5c62ad3).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/Typechecker.ml 72.72% 3 Missing ⚠️
src/middle/UnsizedType.ml 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   90.33%   90.31%   -0.02%     
==========================================
  Files          65       65              
  Lines       10028    10051      +23     
==========================================
+ Hits         9059     9078      +19     
- Misses        969      973       +4     
Files with missing lines Coverage Δ
src/frontend/Semantic_error.ml 95.90% <100.00%> (+0.17%) ⬆️
src/stan_math_signatures/Stan_math_signatures.ml 86.13% <ø> (ø)
src/middle/UnsizedType.ml 82.29% <66.66%> (+0.09%) ⬆️
src/frontend/Typechecker.ml 93.10% <72.72%> (-0.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SteveBronder
Copy link
Contributor

Seems like github is having some sort of issue? I just spun this up with the math branch, but it fails instantly when trying to get stanc3

https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1599/10/pipeline

Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --no-tags --force --progress -- https://github.com/stan-dev/stanc3.git +refs/pull/1599/head:refs/remotes/origin/PR-1599 +refs/heads/master:refs/remotes/origin/master" returned status code 128:
stdout: 
stderr: remote: Internal Server Error
fatal: unable to access 'https://github.com/stan-dev/stanc3.git/': The requested URL returned error: 500

@WardBrian
Copy link
Member Author

@SteveBronder
Copy link
Contributor

Tyty I'll check on the incident status in an hour or so

@SteveBronder SteveBronder merged commit 62af705 into master Mar 4, 2026
1 check passed
@WardBrian WardBrian deleted the laplace-signature-tweaks branch March 4, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants