Fix #60: Merge duplicate factory implementations#62
Open
Conversation
- Consolidate Factory class and _default_input_converter from factory_.py into factory.py - Organize consolidated file with clear sections for better readability: - Factory class implementation - Input conversion utilities - Public API (decorator and functions) - Module exports - Update imports in factory_wrapper.py and factory_executor_manager.py - Fix circular import issues using TYPE_CHECKING - Remove duplicate factory_.py file - Add comprehensive module docstring and section headers All tests pass successfully (22 passed, 2 skipped). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the duplicate factory implementations (
factory.pyandfactory_.py) into a single, well-organized module to eliminate code duplication and improve maintainability.Changes Made
🔄 Code Consolidation
Factoryclass (547 lines) fromfactory_.pyintofactory.py_default_input_converterfunction fromfactory_.pyintofactory.py🔧 Import Updates
factory_wrapper.pyto use consolidated factory modulefactory_executor_manager.pyto use consolidated factory moduleTYPE_CHECKINGand string annotations🗑️ Cleanup
factory_.pyfile__all__exports for clean public interfaceTest Results
All existing tests pass successfully:
Acceptance Criteria Verification
factory.pyexists after completion__all__Benefits
File Size Consideration
The consolidated
factory.pyis 696 lines, which is within reasonable bounds for a core module. The file is well-organized with clear sections that make navigation straightforward.Closes #60
🤖 Generated with Claude Code