feat: add math/base/special/gammaf#10805
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: passed
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
|
/stdlib update-copyright-years |
Coverage Report
The above coverage report was generated for the changes in this PR. |
| xc = q; | ||
| } | ||
| // if ( xc >= 10.0f ) { | ||
| // z = stirlingApprox( xc ); |
There was a problem hiding this comment.
Followed the cephes reference just like how it's followed in gamma. Where they have a fall-through, which cobbles the Stirling result.
The CI/CD marked it as an issue, so I had to comment it out. Anyways, Stirling result is a wasted compute.
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function uses a small value approximation for tiny positive x', function test( t ) { |
There was a problem hiding this comment.
In the reference, the negative recurrence loop is commented out. All negative inputs are handled by the reflection formula.
So,
Only the positive-side test matters, just need to verify smallApprox is triggered when 0 < x < 1e-4 during the positive recurrence.
|
The R fixture runner. R passes lint locally with a newer R version, but the CI runner has R I also put it on zulip: #dev-questions > R lint CI failure — lintr not available for R 3.5.3 |
|
|
||
| w = f32( 1.0 / x ); | ||
| w = f32( 1.0 + f32( w * polyval( w ) ) ); | ||
| y = f32( exp( -x ) ); |
There was a problem hiding this comment.
using exp with float64tofloat32 wrapper on.
Until expf gets merged, this is the workaround.
|
Hey @nirmaljb! I noticed the CI check Here are the fixes needed in
Also, in Hope this helps you get those CI checks green so this awesome PR can get merged! 🚀 |
|
A small advice here to prevent indentation errors in future would be to setup |
math/base/special/gammafmath/base/special/gammaf
Actually, I believe I do have But, anyways, thank you for the suggestion! @Neerajpathak07
|
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
@rautelaKamal Thank you for your feedback! I will fix those inconsistencies. |
|
@nirmaljb just a quick heads-up the Lint error flagged here is for your |

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Progresses #649
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers