feat: add C implementation for @stdlib/stats/base/dists/chi/kurtosis#10837
Open
rautelaKamal wants to merge 9 commits intostdlib-js:developfrom
Open
feat: add C implementation for @stdlib/stats/base/dists/chi/kurtosis#10837rautelaKamal wants to merge 9 commits intostdlib-js:developfrom
@stdlib/stats/base/dists/chi/kurtosis#10837rautelaKamal wants to merge 9 commits intostdlib-js:developfrom
Conversation
- Add C source file (src/main.c) implementing excess kurtosis formula - Add N-API addon wrapper (src/addon.c) - Add C header file (include/stdlib/stats/base/dists/chi/kurtosis.h) - Add build files (binding.gyp, include.gypi, src/Makefile) - Add manifest.json with required C dependencies - Update lib/index.js to load native addon with JS fallback - Add lib/native.js for native addon loading - Add test/test.native.js for native addon tests - Add test/test.main.js for JS fallback path coverage (100% coverage) - Add benchmark/benchmark.native.js and benchmark/c/ - Add examples/c/ Closes stdlib-js#3491
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a native C implementation for
@stdlib/stats/base/dists/chi/kurtosis, resolving issue #3491.The excess kurtosis of a chi distribution with degrees of freedom
kis:where
mu = mean(k),sigma2 = variance(k),sigma = sqrt(sigma2), andg1 = skewness(k).Changes
src/main.cimplementing the kurtosis formula in Csrc/addon.cN-API wrapper usingSTDLIB_MATH_BASE_NAPI_MODULE_D_Dinclude/stdlib/stats/base/dists/chi/kurtosis.hheaderbinding.gyp,include.gypi,src/Makefile)manifest.jsonwith required C library dependencies (mean, variance, skewness, sqrt, is-nan)lib/index.jsto load native addon with pure-JS fallbacklib/native.jsnative addon loadertest/test.native.jsfor native addon testingtest/test.main.jsfor JS fallback coverage (100% coverage)Related Issues
Ref: #3491
Checklist