feat: add blas/ext/base/glast-index-of-row#11929
feat: add blas/ext/base/glast-index-of-row#11929headlessNode wants to merge 6 commits intostdlib-js:developfrom
blas/ext/base/glast-index-of-row#11929Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
No need for 'base.js` |
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Other than missing tests, this is looking good.
Given that changes already need to be made, it would be good to go ahead and update the description of LDA throughout this PR.
| * var out = glastIndexOfRow( 'row-major', 3, 2, A, 2, x, 1 ); | ||
| * // returns 2 | ||
| */ | ||
| ( order: Layout, M: number, N: number, A: InputArray, LDA: number, x: InputArray, strideX: number ): number; |
There was a problem hiding this comment.
@headlessNode I just realized that blas/ext/base/gindex-of-row and blas/ext/base/gindex-of-column are both missing the workspace array arguments. Same applies here.
Did not catch this previously, but we need the blas/ext/base/*index-of-row APIs to all have consistent interfaces. The typed versions (d, s, etc) all support a workspace strided array. We should be consistent here, as well.
The reason being that higher-level ndarray machinery won't know to branch based on dtypes. Instead, higher-level logic will assume that the API signatures are all consistent.
Would you mind updating this PR and opening PRs fixing gindex-of-row and gindex-of-column?
Resolves stdlib-js/metr-issue-tracker#221.
Description
This pull request:
blas/ext/base/glast-index-of-rowRelated Issues
This pull request has the following related issues:
blas/ext/base/glast-index-of-rowmetr-issue-tracker#221Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Primarily written by Claude Code.
@stdlib-js/reviewers