feat: add `ml/base/loss/float64/hinge` by nakul-krishnakumar · Pull Request #11953 · stdlib-js/stdlib

nakul-krishnakumar · 2026-05-05T15:51:39Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: passed
task: lint_c_examples status: passed
task: lint_c_benchmarks status: passed
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

Adds ml/base/loss/float64/hinge.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2026-05-05T15:55:50Z

Coverage Report

No coverage information available.

nakul-krishnakumar · 2026-05-05T15:59:45Z

Clarifications required:

hinge( y, p ) loss function expect y to be either +1 or -1. Should I mention this in the README.md and repl.txt?
Please have a look at the fixture generation and lmk if the approach is apt.
Should I keep y as integer or double? y is the target class label, so it would be an integer, but keeping it as double seems more appropriate.

nakul-krishnakumar · 2026-05-05T16:00:14Z

/stdlib update-copyright-years

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2026-05-05T23:03:33Z

+* limitations under the License.
+*/
+
+#ifndef STDLIB_ML_BASE_FLOAT64_HINGE_H


Suggested change

#ifndef STDLIB_ML_BASE_FLOAT64_HINGE_H

#ifndef STDLIB_ML_BASE_LOSS_FLOAT64_HINGE_H

Guards need to match the package name, NOT the function name. Applies here and below.

kgryte · 2026-05-05T23:04:05Z

+// MAIN //
+
+/**
+* Computes the hinge loss between two double-precision floating-point number.


Suggested change

* Computes the hinge loss between two double-precision floating-point number.

* Computes the hinge loss between two double-precision floating-point numbers.

kgryte · 2026-05-05T23:04:45Z

+	if ( isnan( y ) || isnan( p ) ) {
+		return NaN;
+	}
+	if ( y !== -1.0 && y !== 1.0 ) {


Suggested change

if ( isnan( y ) || isnan( p ) ) {

return NaN;

}

if ( y !== -1.0 && y !== 1.0 ) {

if ( isnan( y ) || isnan( p ) || y !== -1.0 && y !== 1.0 ) {

kgryte · 2026-05-05T23:05:05Z

+// MAIN //
+
+/**
+* Computes the hinge loss between two double-precision floating-point number.


Suggested change

* Computes the hinge loss between two double-precision floating-point number.

* Computes the hinge loss between two double-precision floating-point numbers.

Applies here and throughout this PR.

kgryte · 2026-05-05T23:05:21Z

+	if ( stdlib_base_is_nan( y ) || stdlib_base_is_nan( p ) ) {
+		return STDLIB_CONSTANT_FLOAT64_NAN;
+	}
+	if ( y != -1.0 && y != 1.0 ) {


Suggested change

if ( stdlib_base_is_nan( y ) || stdlib_base_is_nan( p ) ) {

return STDLIB_CONSTANT_FLOAT64_NAN;

}

if ( y != -1.0 && y != 1.0 ) {

if ( stdlib_base_is_nan( y ) || stdlib_base_is_nan( p ) || y != -1.0 && y != 1.0 ) {

kgryte · 2026-05-05T23:05:58Z

+	if ( y != -1.0 && y != 1.0 ) {
+		return STDLIB_CONSTANT_FLOAT64_NAN;
+	}
+	return stdlib_base_max( 0, 1 - ( y*p ) );


Suggested change

return stdlib_base_max( 0, 1 - ( y*p ) );

return stdlib_base_max( 0.0, 1.0 - ( y*p ) );

Floating-point values should have decimals; otherwise, you force implicit casts.

kgryte · 2026-05-05T23:06:13Z

+	if ( y !== -1.0 && y !== 1.0 ) {
+		return NaN;
+	}
+	return max( 0, 1 - ( y*p ) );


Suggested change

return max( 0, 1 - ( y*p ) );

return max( 0.0, 1.0 - ( y*p ) );

kgryte · 2026-05-05T23:09:15Z

+    Computes the hinge loss between two double-precision floating-point number.
+
+    If either argument is `NaN`, the function returns `NaN`.
+    If `y` is not +1 or -1, the function returns `NaN`.


Suggested change

If `y` is not +1 or -1, the function returns `NaN`.

If `y` is not +1 or -1, the function returns `NaN`.

kgryte · 2026-05-05T23:09:42Z

+	hinge( 1.0, ( x: number ): number => x ); // $ExpectError
+}
+
+// The compiler throws an error if the function is provided insufficient arguments...


Suggested change

// The compiler throws an error if the function is provided insufficient arguments...

// The compiler throws an error if the function is provided an unsupported number of arguments...

kgryte · 2026-05-05T23:10:33Z

+		return 1;
+	}
+	return -1;


Suggested change

return 1;

}

return -1;

return 1.0;

}

return -1.0;

Avoid implicit casts.

kgryte

Left initial comments.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

nakul-krishnakumar requested a review from a team May 5, 2026 15:51

stdlib-bot added the Needs Review A pull request which needs code review. label May 5, 2026

nakul-krishnakumar added GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels May 5, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 5, 2026

chore: update copyright years

80993d8

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 5, 2026

nakul-krishnakumar marked this pull request as draft May 5, 2026 17:22

stdlib-bot removed the Needs Review A pull request which needs code review. label May 5, 2026

nakul-krishnakumar marked this pull request as ready for review May 5, 2026 18:01

stdlib-bot added the Needs Review A pull request which needs code review. label May 5, 2026

kgryte reviewed May 5, 2026

View reviewed changes

kgryte requested changes May 5, 2026

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label May 5, 2026

kgryte added Feature Issue or pull request for adding a new feature. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Needs Changes Pull request which needs changes before being merged. review: 3 labels May 5, 2026

nakul-krishnakumar added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels May 6, 2026

nakul-krishnakumar requested a review from kgryte May 6, 2026 05:57

	#ifndef STDLIB_ML_BASE_FLOAT64_HINGE_H
	#ifndef STDLIB_ML_BASE_LOSS_FLOAT64_HINGE_H

	* Computes the hinge loss between two double-precision floating-point number.
	* Computes the hinge loss between two double-precision floating-point numbers.

	return stdlib_base_max( 0, 1 - ( y*p ) );
	return stdlib_base_max( 0.0, 1.0 - ( y*p ) );

	return max( 0, 1 - ( y*p ) );
	return max( 0.0, 1.0 - ( y*p ) );

	If `y` is not +1 or -1, the function returns `NaN`.

	If `y` is not +1 or -1, the function returns `NaN`.

	// The compiler throws an error if the function is provided insufficient arguments...
	// The compiler throws an error if the function is provided an unsupported number of arguments...

Uh oh!

Conversation

nakul-krishnakumar commented May 5, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

nakul-krishnakumar commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nakul-krishnakumar commented May 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented May 5, 2026 •

edited

Loading

nakul-krishnakumar commented May 5, 2026 •

edited

Loading