Skip to content

fix: resolve JavaScript lint errors#11963

Open
nathanaelmbale wants to merge 1 commit intostdlib-js:developfrom
nathanaelmbale:fix/issue-11958
Open

fix: resolve JavaScript lint errors#11963
nathanaelmbale wants to merge 1 commit intostdlib-js:developfrom
nathanaelmbale:fix/issue-11958

Conversation

@nathanaelmbale
Copy link
Copy Markdown

Resolves #11958.

Description

What is the purpose of this pull request?
This pull request:

  • Removes unexpected empty line between require statements in @stdlib/blas/base/sger test file
  • Replaces new Array() constructor with an array literal in @stdlib/assert/is-readable-property benchmark file

Related Issues

Does this pull request have any related issues?
This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?
No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.
I consulted Claude to help me understand the lint errors and the codebase, but the fixes were applied manually by myself.


@stdlib-js/reviewers

@nathanaelmbale nathanaelmbale requested a review from a team May 6, 2026 04:37
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 6, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants