Merged
Conversation
The send to the work channel was blocking the ticker goroutine when all workers were busy, preventing the stopSignal from being processed. Use a nested select to allow the stop signal to interrupt a pending work send. Dropped ticks are logged for observability. fixes 13918
Workers exited when createRequest failed, gradually killing the entire worker pool. Continue to the next work item instead. fixes 13918
Replace the shouldStop callback mechanism with a counter in the ticker goroutine. Workers no longer consume work items without processing them. fixes 13918
joshiste
force-pushed
the
fix/bm-13918
branch
2 times, most recently
from
087e9c4 to
5337c4d
Compare
The periodic http check will cancel any in-flight requests when stopping and won't count these as failure. The fix amount http check will wait for all requests to finish. fixes 13918
joshiste
force-pushed
the
fix/bm-13918
branch
from
5337c4d to
f90c9f9
Compare
When all in-flight requests are cancelled during stop, the success/failed counters are both zero, causing a NaN success rate that silently misbehaves in comparison. Explicitly fail with a clear error message when no requests completed.
joshiste
force-pushed
the
fix/bm-13918
branch
from
e153221 to
f34dc30
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.