Skip to content

fix(diary): UAT Round 4 fixes for auto-events, delivery metadata, signatures, and spacing#895

Merged
steilerDev merged 4 commits intobetafrom
fix/891-894-diary-uat-r4
Mar 16, 2026
Merged

fix(diary): UAT Round 4 fixes for auto-events, delivery metadata, signatures, and spacing#895
steilerDev merged 4 commits intobetafrom
fix/891-894-diary-uat-r4

Conversation

@steilerDev
Copy link
Owner

Summary

This PR implements frontend fixes for 4 diary UAT Round 4 issues:

Changes

Issue #891 - Auto-event display

  • ✅ Already fixed in R3: auto entries show title prominently, body as secondary text
  • Metadata section is hidden for automatic entries (metadata is null)

Issue #892 - Delivery metadata

  • Removed the "Delivery Confirmed" checkbox from delivery form
  • Renamed "Materials" field label to "Description"
  • Updated placeholder text from "Add material" to "Add item"
  • Enhanced DiaryMetadataSummary to display all delivery fields with readable labels:
    • Vendor name
    • Description items displayed as tags

Issue #893 - Signature enhancements

A) Vendor signatory name:

  • When signer type is "vendor", added separate "Signatory Name" input field
  • Signatory name displays as: "Vendor Name (Signatory Name)" in the signature
  • Both vendor and signatory name are required to accept vendor signature

B) Issue entry signatures:

  • Added signature support to "issue" entry type (in addition to daily_log and site_visit)
  • Issue entries can now be signed and acknowledged
  • SignatureSection properly integrated with issue metadata handling

Issue #894 - Visual spacing

  • Added margin-left: auto to .signedBadge in DiaryEntryCard.module.css
  • Pushes the signed badge to the right side of the footer for better visual balance

Files Modified

  1. DiaryEntryCard.module.css: Added margin-left to signedBadge
  2. DiaryEntryForm.tsx:
    • Removed deliveryConfirmed props
    • Added issueSignatures props
    • Added SignatureSection for issue entries
    • Changed delivery field label to "Description"
  3. DiaryEntryDetailPage.tsx: Added "issue" to signature display condition
  4. DiaryMetadataSummary.tsx: Enhanced delivery metadata display with vendor and materials list
  5. DiaryMetadataSummary.module.css: Added styles for delivery metadata display (labels, values, material tags)
  6. SignatureCapture.tsx:
    • Added vendorName and signatoryName state management
    • Show separate "Signatory Name" input when vendor is selected
    • Combine vendor + signatory name in signature display
  7. SignatureCapture.module.css: Added .required class for required field indicators

Test Plan

  • Create delivery entry and verify:
    • "Delivery Confirmed" checkbox is removed
    • Field label is "Description" not "Materials"
    • Delivery metadata displays vendor and items as tags on detail view
  • Create issue entry and verify:
    • Signature section appears below issue metadata
    • Can add signatures (both self and vendor types)
    • Signatures display on detail view
  • Test vendor signature:
    • Select vendor from dropdown
    • Verify "Signatory Name" field appears
    • Verify signature displays as "Vendor Name (Signatory Name)"
    • Verify both fields are required
  • Verify signed badge has proper spacing on card (pushed to right)

🤖 Generated with Claude Code

steilerDev and others added 4 commits March 16, 2026 07:06
Auto-generated diary events now use a cleaner data structure:
- title: brief human-readable summary (e.g., "Status changed from Pending to Paid")
- body: full description without source type prefix (e.g., "INV-001 status changed...")
- metadata: null (removed entirely from auto events)

Previously events stored status details in metadata with body prefixed with "[Source Type]".
Now the title captures the change summary and body provides contextual details.

Fixes #891

Co-Authored-By: Claude backend-developer (Haiku 4.5) <noreply@anthropic.com>
…natures, and spacing

- Issue #891: Auto-event display already fixed in R3
- Issue #892: Remove 'Delivery Confirmed' checkbox, rename 'Materials' to 'Description', improve delivery metadata display with all fields listed
- Issue #893: Add 'Signatory Name' field when signer type is vendor, add signature support to issue entry type
- Issue #894: Add margin-left: auto to .signedBadge for proper spacing

Fixes #891 #892 #893 #894

Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com>
- Remove deliveryConfirmed state, props, and metadata from Create/Edit pages
- Remove deliveryConfirmed test cases from DiaryEntryForm tests
- Update diaryService.test.ts for new createAutomaticDiaryEntry signature
- Update diaryAutoEventService.test.ts: verify title+null metadata instead of metadata objects

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…older

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@steilerDev steilerDev merged commit 5ca23be into beta Mar 16, 2026
38 of 40 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.16.0-beta.42 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant