Skip to content

fix(actions): treat setup-node's NODE_AUTH_TOKEN placeholder as unset #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-kubica merged 2 commits into from
May 13, 2026
Merged

fix(actions): treat setup-node's NODE_AUTH_TOKEN placeholder as unset #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6a109
fix(actions): treat setup-node's NODE_AUTH_TOKEN placeholder as unset
jan-kubica May 13, 2026
b981922
fix(actions): set placeholder NODE_AUTH_TOKEN to empty string, not unset
jan-kubica May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .github/actions/npm-publish-hardened/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,31 @@

set -euo pipefail

# `actions/setup-node@v6` with `registry-url:` exports
# NODE_AUTH_TOKEN=XXXXX-XXXXX-XXXXX-XXXXX as a literal placeholder, so
# its `.npmrc` template `_authToken=${NODE_AUTH_TOKEN}` expands to a
# non-empty (but useless) string. We must neutralise the placeholder
# WITHOUT leaving the variable unset — npm config does env-var
# expansion when reading .npmrc, and an unset variable can leak the
# literal `${NODE_AUTH_TOKEN}` syntax into the Authorization header
# instead of being treated as absent. Setting it to an empty string
# expands cleanly to `_authToken=` (no auth) and lets npm's OIDC
# trusted-publishing path take over.
readonly SETUP_NODE_PLACEHOLDER='XXXXX-XXXXX-XXXXX-XXXXX'
if [[ "${NODE_AUTH_TOKEN:-}" == "${SETUP_NODE_PLACEHOLDER}" ]]; then
export NODE_AUTH_TOKEN=''
fi

# Defence in depth: trusted publishing performs auth via the OIDC token
# exchange. If a legacy token is in env, the publish below would silently
# fall back to bearer auth and the whole point of this action is lost.
# exchange. If a real legacy token is in env, the publish below would
# silently fall back to bearer auth and the whole point of this action
# is lost.
if [[ -n "${NPM_TOKEN:-}" || -n "${NODE_AUTH_TOKEN:-}" ]]; then
# Workflow commands (::error::) must be written to stdout to be picked
# up by the runner's annotation processor; >&2 suppresses the UI
# annotation. This rule applies to every ::error:: line below as well.
printf '::error::NPM_TOKEN/NODE_AUTH_TOKEN must not be set when using %s\n' \
"the hardened publish action — trusted publishing only."
printf '::error::NPM_TOKEN/NODE_AUTH_TOKEN must not be set to a real %s\n' \
"value when using the hardened publish action — trusted publishing only."
exit 2
fi

Expand Down
Loading