Skip to content

fix(actions): emit trailing newline from node-stdout, unblocks read #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-kubica merged 2 commits into from
May 13, 2026
Merged

fix(actions): emit trailing newline from node-stdout, unblocks read #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c429fd7
fix(actions): emit trailing newline from node-stdout, unblocks read
jan-kubica May 13, 2026
cfaba98
fix(actions): adopt console.log + template literal per gemini
jan-kubica May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/npm-publish-hardened/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,14 @@ PKG_JSON_FILE="${RUNNER_TEMP:-/tmp}/npm-publish-hardened-pkg-$$.json"
trap 'rm -f "${PKG_JSON_FILE}"' EXIT
tar -xOf "${TARBALL}" package/package.json > "${PKG_JSON_FILE}"

# shellcheck disable=SC2016 # JS template literals don't need shell expansion
read -r PACKAGE_NAME PACKAGE_VERSION < <(node -e '
const j = JSON.parse(require("fs").readFileSync(process.argv[1], "utf8"));
process.stdout.write((j.name ?? "") + "\t" + (j.version ?? ""));
// console.log appends a trailing newline. The newline is required:
// bash `read` returns non-zero on EOF without a delimiter even when
// the variables were assigned, and under `set -e` that kills the
// script silently right here.
console.log(`${j.name ?? ""}\t${j.version ?? ""}`);
' "${PKG_JSON_FILE}")

if [[ -z "${PACKAGE_NAME}" || "${PACKAGE_NAME}" == "null" \
Expand Down
Loading