Update config docs#5265
Open
drebelsky wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates configuration documentation/comments to reflect that parallel ledger apply and background overlay processing are no longer considered experimental.
Changes:
- Remove the “(experimental)” note from
BACKGROUND_OVERLAY_PROCESSINGandPARALLEL_LEDGER_APPLYcomments inConfig.h. - Update the example config to use
PARALLEL_LEDGER_APPLY(and reflect its current default) instead of the deprecatedEXPERIMENTAL_PARALLEL_LEDGER_APPLY. - Clarify that parallel ledger apply is only incompatible with in-memory SQLite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/Config.h | Removes “experimental” wording from config field comments. |
| docs/stellar-core_example.cfg | Updates example config key/value and associated docs for PARALLEL_LEDGER_APPLY. |
Contributor
|
LGTM! Feel free to squash and we can merge |
* Fix stellar-core_example.cfg PARALLEL_LEDGER_APPLY documentation * Remove experimental notes for non-experimental config flags in Config.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates to
PARALLEL_LEDGER_APPLYto reflect current non-experimental status; also, removes the(experimental)note fromBACKGROUND_OVERLAY_PROCESSING's comment