Add instance parameter to apply_load_aws script.#5281
Open
dmkozh wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an --instance-type CLI parameter to the aws-init flow of the apply-load AWS orchestration script, allowing callers to customize the EC2 instance type used for apply-load runs while preserving the prior default.
Changes:
- Replace the hard-coded
INSTANCE_TYPEconstant withDEFAULT_INSTANCE_TYPE. - Thread an
instance_typeparameter throughaws_init()intostart_ec2_instance(). - Add
--instance-typeto theaws-initsubcommand with a default ofc5d.2xlarge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add instance parameter to apply_load_aws script for the sake of customization.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)