Skip to content

Add instance parameter to apply_load_aws script.#5281

Open
dmkozh wants to merge 1 commit into
stellar:masterfrom
dmkozh:apply_load_aws_instance
Open

Add instance parameter to apply_load_aws script.#5281
dmkozh wants to merge 1 commit into
stellar:masterfrom
dmkozh:apply_load_aws_instance

Conversation

@dmkozh
Copy link
Copy Markdown
Contributor

@dmkozh dmkozh commented May 20, 2026

Description

Add instance parameter to apply_load_aws script for the sake of customization.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Copilot AI review requested due to automatic review settings May 20, 2026 23:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an --instance-type CLI parameter to the aws-init flow of the apply-load AWS orchestration script, allowing callers to customize the EC2 instance type used for apply-load runs while preserving the prior default.

Changes:

  • Replace the hard-coded INSTANCE_TYPE constant with DEFAULT_INSTANCE_TYPE.
  • Thread an instance_type parameter through aws_init() into start_ec2_instance().
  • Add --instance-type to the aws-init subcommand with a default of c5d.2xlarge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants