Skip to content

Conversation

@dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jan 20, 2026

Not including that was an oversight, given that we're already increasing the footprint size and write entries to 200 entries.

Not including that was an oversight, given that we're already increasing the footprint size and write entries to 200 entries.
Copilot AI review requested due to automatic review settings January 20, 2026 18:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing "Disk Read Entries" row to the resource limits table in SLP-0004, documenting an increase from 100 to 200 entries per transaction. This aligns with other already-proposed increases to footprint size and write entries.

Changes:

  • Added "Disk Read Entries" row to the proposed limits table with an increase from 100 to 200 per-tx entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@anupsdf anupsdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need a one-liner on disk read entries per tx in the Increase of the transaction limits section?

@dmkozh
Copy link
Contributor Author

dmkozh commented Jan 20, 2026

Do we also need a one-liner on disk read entries per tx in the Increase of the transaction limits section?

There is no per-resource breakdown in this section and I don't think there is anything particular about the disk reads increase, the ledger/tx ratio for it is the same as for most of the other resources.

@dmkozh dmkozh merged commit 0ba8b98 into stellar:master Jan 20, 2026
11 checks passed
@dmkozh dmkozh deleted the slp4_tx_reads branch January 20, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants