Skip to content

Typehint parameters in accordance with ContainerInterface#21

Open
dnwjn wants to merge 1 commit intostellarwp:masterfrom
dnwjn:patch-1
Open

Typehint parameters in accordance with ContainerInterface#21
dnwjn wants to merge 1 commit intostellarwp:masterfrom
dnwjn:patch-1

Conversation

@dnwjn
Copy link
Copy Markdown

@dnwjn dnwjn commented Aug 8, 2024

Hi team!

We ran into an issue with the Restrict Content plugin and the WP CLI. We would get the following exception:

PHP Fatal error:  Declaration of Illuminate\Container\Container::get(string $id) must be compatible with Psr\Container\ContainerInterface::get($id) in /<redacted>/vendor/illuminate/container/Container.php on line 714

We pinpointed the issue to be in your plugin as disabling it, or typehinting the parameters as done in this PR, would resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant