fix make sure maintain the same referential equality even after using proxy#151
Open
tanhauhau wants to merge 1 commit intostephencookdev:masterfrom
Open
fix make sure maintain the same referential equality even after using proxy#151tanhauhau wants to merge 1 commit intostephencookdev:masterfrom
tanhauhau wants to merge 1 commit intostephencookdev:masterfrom
Conversation
Owner
|
Thanks for raising this @tanhauhau! I've just checked this out locally — unfortunately I don't think it works fully as expected :( You can see it's breaking some of the functional-tests, e.g. v3-stats The reason why is because the way this sets up a global wrap of each object, it means e.g. once a This is a bit of an interesting problem 🤔 I'm not entirely sure off the top of my head how to fix. I'll give it some thought, but let me know if you have any ideas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
html-webpack-plugin's hook relies on referential equality ofcompilationinstance. (see https://github.com/jantimon/html-webpack-plugin/blob/master/lib/hooks.js#L77-L85)Currently, creating a new proxy every time breaks that referential equality.
This fix uses
WeakMapto make sure to reuse the same proxy when passing the samecompilationinstance.