Skip to content

feat: add options.outputStripAnsi#179

Open
55utah wants to merge 1 commit intostephencookdev:masterfrom
55utah:feature/add-output-format
Open

feat: add options.outputStripAnsi#179
55utah wants to merge 1 commit intostephencookdev:masterfrom
55utah:feature/add-output-format

Conversation

@55utah
Copy link
Copy Markdown

@55utah 55utah commented Oct 28, 2021

What I do:
Add new option outputStripAnsi, it can clear output's color and style.
Reason:
Plugin use chalk, when outputTarget is function, it will get unreadable text, someone already asked this question. with outputStripAnsi, outputTarget function can get plain text output.

@55utah
Copy link
Copy Markdown
Author

55utah commented Oct 28, 2021

I already test it and get success, but I failed to create a test case .. >_< .. sorry.

@shwarcu
Copy link
Copy Markdown

shwarcu commented Nov 5, 2021

@stephencookdev Hi, could you take a look at these pull requests? Are you still maintaining the project?

@stephencookdev
Copy link
Copy Markdown
Owner

@stephencookdev Hi, could you take a look at these pull requests? Are you still maintaining the project?

Struggling to stay on top of everything definitely 😴 But this change looks good. Let me take a look this weekend and see about getting this released. Thanks for the PR @55utah! 🙂

@shwarcu
Copy link
Copy Markdown

shwarcu commented Nov 5, 2021

@stephencookdev thanks for responding! 😊 I was looking at this repo for some time and configured it in the project I work in. I was wondering if you are still present here because I will probably try to contribute and I just didn't want to spend plenty of time preparing a PR and then not be noticed 😅

@55utah
Copy link
Copy Markdown
Author

55utah commented Nov 16, 2021

@stephencookdev @shwarcu Please take a look. ❤️

@shwarcu
Copy link
Copy Markdown

shwarcu commented Nov 16, 2021

Looks legit to me 😅

@stephencookdev
Copy link
Copy Markdown
Owner

Hey @55utah — I have recently made the move to launch 18ways.com (AI-first, keyless i18n infra), and more generally try to make a living out of making devs lives' less awful.

As such, SMP has now been bumped to v1.6, adding Webpack 5 support, and I'm going to be engaging more closely with issues over the next few weeks!

This PR still feels massively needed, and I'll work on getting this merged for a v1.7 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants