Supports webpack5 and mini-css-extract-plugin#199
Open
sunft1996 wants to merge 1 commit intostephencookdev:masterfrom
Open
Supports webpack5 and mini-css-extract-plugin#199sunft1996 wants to merge 1 commit intostephencookdev:masterfrom
sunft1996 wants to merge 1 commit intostephencookdev:masterfrom
Conversation
f543839 to
1a804dd
Compare
|
Worked for me - thanks! In case this repo is still maintained, this should definitely be merged. @stephencookdev |
|
Why don't you merge it? @stephencookdev |
|
@stephencookdev merge please |
|
For those who can't run the plugin on the 5th webpack:
For example, in my case, it was the After that you will be able to run the plugin even with the webpack@5 FYI @tanchu @sunft1996 Great effort, man. You helped a lot. |
|
@sharikovvladislav Thanx! |
|
@sunft1996 can you use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports webpack5 and mini-css-extract-plugin, with the following 3 changes:
tap/tapAsync/tapPromisefunction, as mini-css-extract-plugin will use thecompilationparameter passed to the tap function(code here), but it will get the proxy object instead of itself, which causes some bugs.compilerfor a similar reason as the first one, as some plugins require the original method, such asmini-css-extract-plugin, which usescompile.webpackas the cache. code herenormal-module-loaderhook, although it can still be used now, it will be removed in the future.I ran through all the test cases and it seems to be okay. I hope it helps :)