Skip to content

(Closes #2381) alternative approach to global reduction#3222

Closed
arporter wants to merge 3 commits intomasterfrom
2381_no_domain_global_reduction
Closed

(Closes #2381) alternative approach to global reduction#3222
arporter wants to merge 3 commits intomasterfrom
2381_no_domain_global_reduction

Conversation

@arporter
Copy link
Copy Markdown
Member

@arporter arporter commented Nov 14, 2025

Refactors the existing support for global sums and begins adding support for global max/min.

@arporter arporter self-assigned this Nov 14, 2025
@arporter arporter marked this pull request as draft November 14, 2025 16:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (16639e7) to head (653c9bd).
⚠️ Report is 126 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3222   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         380      380           
  Lines       53916    53916           
=======================================
  Hits        53894    53894           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Copy Markdown
Member Author

The testing was becoming increasingly artificial as I didn't have any "legitimate" way to introduce kernels with gh_min or gh_max access. Therefore I've started looking at adding the actual builtin(s) that will use these new accesses. #2674 requests support for field_min_max so I've begun adding that. However, I've then tripped over the fact that we currently enforce the requirement for a kernel/builtin to have only 1 or 0 reductions and min-max needs 2.

@arporter
Copy link
Copy Markdown
Member Author

Somehow or other I lost the changes on this branch so I'm closing it.

@arporter arporter closed this Feb 16, 2026
@arporter arporter deleted the 2381_no_domain_global_reduction branch February 16, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant