Skip to content

(Closes #3314) fix line limit bug for in-line comments#3316

Merged
LonelyCat124 merged 8 commits intomasterfrom
3314_line_limit_bug
Feb 10, 2026
Merged

(Closes #3314) fix line limit bug for in-line comments#3316
LonelyCat124 merged 8 commits intomasterfrom
3314_line_limit_bug

Conversation

@arporter
Copy link
Copy Markdown
Member

@arporter arporter commented Feb 3, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (2ddfa87) to head (50e94ff).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3316   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         380      380           
  Lines       53918    53936   +18     
=======================================
+ Hits        53896    53914   +18     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Copy Markdown
Member Author

arporter commented Feb 4, 2026

I've fired off the ITs. One for @LonelyCat124, @hiker or @sergisiso to review :-)

@arporter arporter self-assigned this Feb 4, 2026
Comment thread src/psyclone/line_length.py Outdated
Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me - I had one question (depending on how complex long_lines would need to become) and one update to the documentation.

You also need to update the author list for these files.

Comment thread src/psyclone/line_length.py Outdated
@arporter
Copy link
Copy Markdown
Member Author

arporter commented Feb 6, 2026

Should be ready for another look now.

Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter Almost there - I noticed one missing type hint so I've also asked if you can go through the file in full and just add the other missing ones even to parts you've not touched to bring this file fully up to our new standards. There's also a docstring member missing from before so I've asked for that as well.

Comment thread src/psyclone/line_length.py Outdated
Comment thread src/psyclone/line_length.py Outdated
Comment thread src/psyclone/line_length.py Outdated
Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this now, will proceed to merge.

@LonelyCat124 LonelyCat124 merged commit 71ebd87 into master Feb 10, 2026
15 checks passed
@LonelyCat124 LonelyCat124 deleted the 3314_line_limit_bug branch February 10, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants