(Closes #3314) fix line limit bug for in-line comments#3316
(Closes #3314) fix line limit bug for in-line comments#3316LonelyCat124 merged 8 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 380 380
Lines 53918 53936 +18
=======================================
+ Hits 53896 53914 +18
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've fired off the ITs. One for @LonelyCat124, @hiker or @sergisiso to review :-) |
LonelyCat124
left a comment
There was a problem hiding this comment.
Mostly looks good to me - I had one question (depending on how complex long_lines would need to become) and one update to the documentation.
You also need to update the author list for these files.
|
Should be ready for another look now. |
LonelyCat124
left a comment
There was a problem hiding this comment.
@arporter Almost there - I noticed one missing type hint so I've also asked if you can go through the file in full and just add the other missing ones even to parts you've not touched to bring this file fully up to our new standards. There's also a docstring member missing from before so I've asked for that as well.
LonelyCat124
left a comment
There was a problem hiding this comment.
Happy with this now, will proceed to merge.
No description provided.