Skip to content

(closes #3432) Transformation functionality to split and propagate kwargs to subtransformations#3433

Merged
LonelyCat124 merged 9 commits into
masterfrom
3432_split_and_propagate_kwargs
May 15, 2026
Merged

(closes #3432) Transformation functionality to split and propagate kwargs to subtransformations#3433
LonelyCat124 merged 9 commits into
masterfrom
3432_split_and_propagate_kwargs

Conversation

@sergisiso
Copy link
Copy Markdown
Collaborator

No description provided.

@sergisiso sergisiso requested a review from LonelyCat124 May 14, 2026 14:32
@sergisiso sergisiso self-assigned this May 14, 2026
@sergisiso
Copy link
Copy Markdown
Collaborator Author

@LonelyCat124 This is ready for a first look.

For now I added a manual docstring mention that creates the correct link (see image). Maybe it can also be done automatically in docstring_parser.py, but I couldn't figure out where.
image

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (ca8610a) to head (99df5b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3433   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         391      391           
  Lines       54609    54668   +59     
=======================================
+ Hits        54590    54649   +59     
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergisiso I think this looks mostly good to me - I have some slight reservations with the tests (and not reaching some fail cases that I think it should as written now, with a better way to write some parts) so I've asked for a few changes and an additional test.

Comment thread src/psyclone/tests/psyGen_test.py Outdated
Comment thread src/psyclone/psyGen.py Outdated
Comment thread src/psyclone/psyGen.py Outdated
@sergisiso
Copy link
Copy Markdown
Collaborator Author

@LonelyCat124 This is ready for another review

@LonelyCat124
Copy link
Copy Markdown
Collaborator

@sergisiso Have a couple more suggestions but I think we're closer now.

We probably need a section in the docs discussing metatransformations (or transformations that primarily call other transformations, or some other title you prefer) and what is supported (This stuff) and what isn't (doc option inheritance) with perhaps a TODO to either #3330 or a new issue. I think this subtransformation stuff should probably make doc option inheritance a lot easier for metatransformations, but I'll investigate it in #3345 .

I think w.r.t #3431 this will enable option support (with small changes) and then we add a TODO for the undocumented inherited arguments again.

@sergisiso
Copy link
Copy Markdown
Collaborator Author

@LonelyCat124 I adressed your comments, added documentation and fixed outdated links to bitbucket that were making the linkcheck fail. Ready for another view

Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and ITs pass, will proceed to merge.

@LonelyCat124 LonelyCat124 merged commit b45ff81 into master May 15, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants