(closes #3432) Transformation functionality to split and propagate kwargs to subtransformations#3433
Conversation
|
@LonelyCat124 This is ready for a first look. For now I added a manual docstring mention that creates the correct link (see image). Maybe it can also be done automatically in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3433 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 391 391
Lines 54609 54668 +59
=======================================
+ Hits 54590 54649 +59
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LonelyCat124
left a comment
There was a problem hiding this comment.
@sergisiso I think this looks mostly good to me - I have some slight reservations with the tests (and not reaching some fail cases that I think it should as written now, with a better way to write some parts) so I've asked for a few changes and an additional test.
|
@LonelyCat124 This is ready for another review |
|
@sergisiso Have a couple more suggestions but I think we're closer now. We probably need a section in the docs discussing metatransformations (or transformations that primarily call other transformations, or some other title you prefer) and what is supported (This stuff) and what isn't (doc option inheritance) with perhaps a TODO to either #3330 or a new issue. I think this subtransformation stuff should probably make doc option inheritance a lot easier for metatransformations, but I'll investigate it in #3345 . I think w.r.t #3431 this will enable option support (with small changes) and then we add a TODO for the undocumented inherited arguments again. |
|
@LonelyCat124 I adressed your comments, added documentation and fixed outdated links to bitbucket that were making the linkcheck fail. Ready for another view |
LonelyCat124
left a comment
There was a problem hiding this comment.
All looks good and ITs pass, will proceed to merge.

No description provided.