(closes #3135) Fix cyclic dependencies by replacing Scalartype import-time instantiations#3436
Open
sergisiso wants to merge 7 commits into
Open
(closes #3135) Fix cyclic dependencies by replacing Scalartype import-time instantiations#3436sergisiso wants to merge 7 commits into
sergisiso wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3436 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 391 391
Lines 54668 54692 +24
=======================================
+ Hits 54649 54673 +24
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@LonelyCat124 @arporter This is ready for review |
LonelyCat124
requested changes
May 19, 2026
Collaborator
LonelyCat124
left a comment
There was a problem hiding this comment.
@sergisiso I struggled to look through every single change (my browser is dying looking at the diffs...) but I found some minor issues to check with imports in examples and docs - can you check these? Then I can probably merge.
Collaborator
Author
|
@LonelyCat124 This is ready for another review. |
Collaborator
|
Set ITs running as a sanity check but otherwise all is good. |
Collaborator
Author
|
@LonelyCat124 the integration test spotted a INTEGER_TYPE in lfric_apps. I will push a fix now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit #3135 again where some cyclic dependencies cannot be prevented by adding the import inside methods because they happen when symbols are initialised at import-time. To remove this import time instantiations I opted for creating ScalarType staticmethods instead of the factory proposed in the issue. The change itself is small, but it is repeated many many times.