Allow CommandProvider to "re-initialize" fresh web driver#175
Open
ffMathy wants to merge 2 commits intostirno:devfrom
Open
Allow CommandProvider to "re-initialize" fresh web driver#175ffMathy wants to merge 2 commits intostirno:devfrom
ffMathy wants to merge 2 commits intostirno:devfrom
Conversation
…ar the "lazy cache" of the driver used in the command provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if I decide to use FluentAutomation and I want to switch driver at runtime or I want to kill and re-open the driver because it has been exhausted due to memory issues, I can't, since the
CommandProviderhas cached the oldIWebDriverinstance.This solution proposal adds a new
protectedmethod that allows me to clear that cache and force a re-initialization.Please let me know what you think.