Skip to content

chore: remove Cohere from required integ test providers#1967

Merged
zastrowm merged 1 commit intostrands-agents:mainfrom
zastrowm:remove_cohere
Mar 25, 2026
Merged

chore: remove Cohere from required integ test providers#1967
zastrowm merged 1 commit intostrands-agents:mainfrom
zastrowm:remove_cohere

Conversation

@zastrowm
Copy link
Member

Description

The Cohere API key used in CI is being revoked out of an abundance of safety after the LiteLLM dependency chain issue. While we sort out a proper key, removing it from the required providers list prevents the entire integration test session from failing when the key is absent.

Related Issues

N/A

Documentation PR

N/A

Type of Change

Bug fix

Testing

Verified the required_providers set no longer includes COHERE_API_KEY, so a missing key results in skipped tests rather than a session-level failure.

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

For the LiteLLM issue we revoked all api keys and we now need to get a new official cohere testing key; until that time, we'll remove this from the required set of tests
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

Assessment: Approve

Clean, focused change that addresses a legitimate security concern. The modification appropriately converts a session-level failure into graceful test skipping for Cohere tests.

Review Notes
  • Change Scope: Single line removal from required_providers set - minimal and well-contained
  • Test Behavior: Cohere tests will continue to work normally when the API key is present; when absent, tests are skipped via providers.cohere.mark rather than failing the entire session
  • Documentation: Not required (CI/config change only)

LGTM! 👍

@zastrowm zastrowm marked this pull request as ready for review March 25, 2026 14:40
@zastrowm zastrowm enabled auto-merge (squash) March 25, 2026 14:42
@zastrowm zastrowm merged commit a110149 into strands-agents:main Mar 25, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants