chore: remove Cohere from required integ test providers#1967
Merged
zastrowm merged 1 commit intostrands-agents:mainfrom Mar 25, 2026
Merged
chore: remove Cohere from required integ test providers#1967zastrowm merged 1 commit intostrands-agents:mainfrom
zastrowm merged 1 commit intostrands-agents:mainfrom
Conversation
For the LiteLLM issue we revoked all api keys and we now need to get a new official cohere testing key; until that time, we'll remove this from the required set of tests
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Assessment: Approve Clean, focused change that addresses a legitimate security concern. The modification appropriately converts a session-level failure into graceful test skipping for Cohere tests. Review Notes
LGTM! 👍 |
mkmeral
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Cohere API key used in CI is being revoked out of an abundance of safety after the LiteLLM dependency chain issue. While we sort out a proper key, removing it from the required providers list prevents the entire integration test session from failing when the key is absent.
Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
Verified the required_providers set no longer includes
COHERE_API_KEY, so a missing key results in skipped tests rather than a session-level failure.hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.