BUG FIX: Add null check for $pmpro_level in checkout events#9
Open
flintfromthebasement wants to merge 1 commit intostrangerstudios:devfrom
Conversation
Fixes a PHP warning 'Attempt to read property on null' thrown when $pmpro_level is not populated on the checkout page. This can happen when bots, crawlers, or redirects hit the checkout URL without a valid level context. Added an early return guard to prevent accessing properties on a null object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a null check for the global
$pmpro_levelvariable inpmproga4_checkout_events()to prevent fatal errors when the membership level is not set.The Bug
pmproga4_checkout_events()runs on checkout page load and immediately accesses$pmpro_level->id,$pmpro_level->name, and$pmpro_level->initial_paymentwithout checking if the global is set. This causes a fatal error (or PHP warnings/notices) when$pmpro_levelis null — which can happen in edge cases like direct page access or when another plugin interferes with the checkout flow.The Fix
Added an early return when
$pmpro_levelis empty, following the same guard pattern already used in the function forpmpro_is_checkout():Testing