Skip benchmark job on fork PRs#1094
Open
keyboardDrummer-bot wants to merge 1 commit intostrata-org:mainfrom
Open
Skip benchmark job on fork PRs#1094keyboardDrummer-bot wants to merge 1 commit intostrata-org:mainfrom
keyboardDrummer-bot wants to merge 1 commit intostrata-org:mainfrom
Conversation
The strata-benchmarks job requires secrets.AWS_BENCHMARK_ACCOUNT which is not available on pull requests from forks. Add a condition to skip the job when the PR originates from a different repository.
github-actions
Bot
added
the
github_actions
tautschnig
approved these changes
May 1, 2026
robin-aws
requested changes
May 1, 2026
Contributor
robin-aws
left a comment
robin-aws
left a comment
There was a problem hiding this comment.
We need to ensure the benchmark job is run before anything's merged. We're documenting the process for contributors in https://github.com/strata-org/Strata/pull/1086/changes instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip the
strata-benchmarksCI job on pull requests from forks.Problem
The benchmark job uses
secrets.AWS_BENCHMARK_ACCOUNTto assume an IAM role and trigger AWS CodeBuild. This secret is not available to workflows running on fork PRs, causing the job to always fail for external contributors.Fix
Add a job-level
ifcondition that skips the benchmark job when the PR comes from a fork:This means:
pushto main: runs (secrets available)merge_group: runs (secrets available)Requested in keyboardDrummer#7 (comment)