Prefix destructors with datatype name #340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shigoel
previously approved these changes
Jan 23, 2026
Strata/DL/Lambda/TypeFactory.lean
Outdated
| def destructorFuncs {T} [BEq T.Identifier] [Inhabited T.IDMeta] (d: LDatatype T.IDMeta) (c: LConstr T.IDMeta) : List (LFunc T) := | ||
| c.args.mapIdx (fun i (name, ty) => | ||
| let arg := genArgName | ||
| let destructorName : Identifier T.IDMeta := d.name ++ ".." ++ name.name |
Contributor
There was a problem hiding this comment.
Nit: Perhaps makes sense to define a separate function to create these scoped names to make sure it's easy to be consistent across files and that if we change naming later (unlikely, but still...), the delta will be small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Changes the syntax so that datatype declarations automatically produce destructors of the form
Name..destructor(e.g.List..headas opposed tohead). This enables one to reuse destructor names across different datatypes (as inCorePrelude.lean). Most of this PR fixes tests, the only (small) changes are inTypeFactory.lean,Core/Parse.lean,Core/DDMTransform/Translate.lean, andCore/SMTEncoder.lean. This PR also updates the documentation.@thanhnguyen-aws
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.