Add sink selection to evm-hello-world generator #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the missing sink question to the evm-hello-world generator by integrating pre-shared and post-shared flow handling, making it consistent with other EVM modules and hello-world generators. Changes: - Added sharedFlowConfig to enable pre/post shared flows - Updated NextStep() to use IsPreSharedFlowDone and NextPostSharedFlowStep - Updated Update() to delegate pre/post shared flow message handling - Removed direct handling of MsgStart, AskProjectName, InputProjectName, RunGenerate, ReturnGenerate, InputSubstreamsConsumptionChoice, and InputSourceDownloaded (now handled by shared flow) - Updated test to include initial block and sink choice steps Fixes BLO-807 Co-authored-by: maoueh <123014+maoueh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing sink question in evm-hello-world generator
Add sink selection to evm-hello-world generator
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
evm-hello-worldgenerator was missing the sink consumption question that other EVM generators and hello-world templates include, preventing users from configuring output destinations (Postgres, Clickhouse, Parquet, custom sinks).Changes
Integrated shared flow pattern: Added pre/post shared flow handling to match other hello-world generators (mantra, injective, starknet)
sharedFlowConfigwithValidChains: nilNextStep()to checkIsPreSharedFlowDone()and callNextPostSharedFlowStep()UpdatePreSharedFlowMsg()andUpdatePostSharedFlowMsg()Removed redundant code: Eliminated direct handling of
MsgStart,AskProjectName,InputProjectName,RunGenerate,ReturnGenerate, and sink-related messages now handled by shared flowsUpdated tests: Added verification for initial block and sink choice steps
Flow impact
Net -10 lines of code with cleaner separation of concerns.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.