Make JSON serialization opt-in via generateJson flag#7
Open
merlimat wants to merge 1 commit intostreamnative:masterfrom
Open
Make JSON serialization opt-in via generateJson flag#7merlimat wants to merge 1 commit intostreamnative:masterfrom
merlimat wants to merge 1 commit intostreamnative:masterfrom
Conversation
JSON serialization (writeJsonTo/parseFromJson/toJson) was always generated on every message, adding code size that's only useful for projects that actually need a JSON representation. Mirror what generateTextFormat already does and make JSON opt-in: - New generateJson option on the Maven plugin (boolean parameter, default false) and the Gradle plugin (LightProtoExtension property, default false). - LightProtoMessage skips generateWriteJsonTo/generateParseFromJson when the flag is off. - writeJsonTo/parseFromJson removed from the LightProtoMessage interface so messages compile cleanly without them; the generated toJson() now inlines the small ByteBuf-to-String body that the static helper used to provide. The tests/pom.xml sets generateJson=true so the existing JSON test suite continues to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan