fix: Re-add the minimum value when calculating nearest tick for Slider's#3109
Open
Acissathar wants to merge 1 commit intostride3d:masterfrom
Open
fix: Re-add the minimum value when calculating nearest tick for Slider's#3109Acissathar wants to merge 1 commit intostride3d:masterfrom
Acissathar wants to merge 1 commit intostride3d:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
CalculateClosestTick in Slider.cs subtracts the Minimum to convert into a relative offset, does the tick-snapping math in that relative space, but then returns times * step without translating it back to the absolute value. This makes it so that any value you enter is going to have the Minimum subtracted from it when Minimum is a non-zero value, even if this makes the value go below the Minimum.
Adding it back in at the very end makes both the value and minimum be respected:
Related Issue
#3108
Types of changes
Checklist