fix: swallowing mpp errors#93
Merged
raubrey-stripe merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: mpp pay returns structured { status, headers, body } when the initial probe gets a non-402 response, but throws a plain error on the settlement-retry (second request after the 402 handshake). The throw flattens status, headers, and body into a single error
message string, making it impossible for agents to parse the merchant's response programmatically.
Root cause: readPayResult(response, { failOnError: true }) on the retry path throws on non-2xx instead of returning the structured envelope.
Fix: Removed failOnError entirely. The retry path now returns { status, headers, body } for all HTTP responses, matching the probe path's behavior. The agent inspects status to determine the outcome.