enfore the format in the ci, script to fail locally if version are di…#354
Open
enfore the format in the ci, script to fail locally if version are di…#354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strictly enforces Prettier formatting in CI and locks the Prettier version to prevent local drift.
Changes
continue-on-error: truefrom the formatting check step in.github/workflows/ci.yml.package.jsonto pinprettierexactly to3.6.2(removing the^) to prevent accidental version drift.scripts/check-prettier-version.jsscript that validates the locally installed Prettier version against the exact resolution inpnpm-lock.yamlas a part of thepnpm formatandpnpm format:checkscripts. If a local version is out of sync, the script will immediately exit with an error, prompting you to runpnpm install.Testing
I've tested locally by installing a different version of prettier and running
pnpm format, this resulted in an error: