Fixed docker build.

[tlc]

Minor problems, apparently from kaldi changes, caused the docker build to fail.

#164

[tlc]

Just FYI, I have no idea if python3 is really being used. But it's checked for in
gentle/ext/kaldi/tools/extras/check_dependencies.sh

[strob]

Thank you for the patch!

[tlc]

Hmm, failed travis because travis does this:

• docker run --rm lowerquality/gentle sh -c "cd /gentle && python setup.py nosetests"

The nose stuff was added here

a374828#diff-2eeaed663bd0d25b7e608891384b7298

then partially removed here (2 years ago):

5452700#diff-2eeaed663bd0d25b7e608891384b7298

Not sure if you want to put 'nose' back in setup.py or remove it from .travis.yml ....

Can this be merged?

[strob]

I am not interested in maintaining nose support. Let's take it out.

[denistsoi]

Getting following error when building with docker -

want to confirm if anyone can correctly build with 479af55

Doing OS specific configurations ...
On Linux: Checking for linear algebra header files ...
***configure failed: Must specify the location of OPENBLAS with --openblas-root option (and it must exist) ***
Makefile:30: kaldi.mk: No such file or directory
kaldi.mk does not exist; you have to run ./configure
Makefile:96: recipe for target 'kaldi.mk' failed
make: *** [kaldi.mk] Error 1
Makefile:5: kaldi/src/kaldi.mk: No such file or directory
make: *** No rule to make target 'kaldi/src/kaldi.mk'.  Stop.
The command '/bin/sh -c MAKEFLAGS=' -j8' cd /gentle/ext && 	./install_kaldi.sh && 	make && rm -rf kaldi *.o' returned a non-zero code: 2

[tlc]

I built the docker image locally using the changes in this pull. The tricks:

1. You must do it in a clean directory -- no non-docker build residue -- or it will pick up paths and elements from your non-docker builds. This is because the Dockerfile does ADDs and configure/make.
2. Except, you must do the 'git submodule init' and 'git submodule update' commands (from install.sh). Apparently github travis and hub.docker.com do this automatically?

[tlc]

@strob , I don't know enough about what travis is doing to finish this off. What's the change for line 12? Or do we remove the last 2 lines? Remove .travis.yml?

[strob]

Unfortunately I am not actively using the docker image and also don't know how Travis works. I am happy to accept a PR if others find the Docker support useful.

…

On Thu, May 24, 2018 at 12:55 PM, tlc ***@***.***> wrote: @strob <https://github.com/strob> , I don't know enough about what travis is doing to finish this off. What's the alternative for line 12? Or do we remove the last 2 lines? Remove .travis.yml? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#165 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMup0YagE-3HwuJJm0xlAcKyJBDpORqks5t1pG8gaJpZM4UJDNt> .

[denistsoi]

@tlc - yeah... tried building via a clean directory wuth relative build path docker build -t gentle:latest <path-to-source> but still getting the above error.

Thinking I may have to go down the git submodule route -
wondering how you had achieved this build? - Advanced Thanks~

[tlc]

@denistsoi

Step 8/10 : EXPOSE 8765
 ---> Running in 9b0c2893e999
 ---> fcf741273140
Removing intermediate container 9b0c2893e999
Step 9/10 : VOLUME /gentle/webdata
 ---> Running in 44d517e1037f
 ---> 9cc37a4f4299
Removing intermediate container 44d517e1037f
Step 10/10 : CMD cd /gentle && python serve.py
 ---> Running in 253ef75f3cf0
 ---> 5fb9a1eb3e04
Removing intermediate container 253ef75f3cf0
Successfully built 5fb9a1eb3e04
$ history |tail -n5
 2004  git clone https://github.com/tlc/gentle.git .
 2005  git submodule init
 2006  git submodule update
 2007  sudo docker build  .
 2008  history |tail -n5

[denistsoi]

Cool! Thanks @tlc appreciate the walkthrough!

On Thu, 24 May 2018 at 9:06 PM, tlc ***@***.***> wrote: @denistsoi <https://github.com/denistsoi> Step 8/10 : EXPOSE 8765 ---> Running in 9b0c2893e999 ---> fcf741273140 Removing intermediate container 9b0c2893e999 Step 9/10 : VOLUME /gentle/webdata ---> Running in 44d517e1037f ---> 9cc37a4f4299 Removing intermediate container 44d517e1037f Step 10/10 : CMD cd /gentle && python serve.py ---> Running in 253ef75f3cf0 ---> 5fb9a1eb3e04 Removing intermediate container 253ef75f3cf0 Successfully built 5fb9a1eb3e04 ***@***.***:~/gentile3$ history |tail -n5 2004 git clone https://github.com/tlc/gentle.git . 2005 git submodule init 2006 git submodule update 2007 sudo docker build . 2008 history |tail -n5 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#165 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC64E4HDDeax5fNhCGRs-vWwYQ8mDXI-ks5t1rBWgaJpZM4UJDNt> .

-- .

[tlc]

@stob It looks like you cherry-picked parts of this commit. If you add the 'gfortran' reference, too, your travis CI won't fail here:

https://travis-ci.org/lowerquality/gentle/builds/383106741?utm_source=github_status&utm_medium=notification&highlight-=gfortran

(it'll fail later), and your docker hub pushes should work

https://hub.docker.com/r/lowerquality/gentle/builds/
https://hub.docker.com/r/lowerquality/gentle/builds/bzjl9tcayjmab3vbgvewkvm/