Require linked-hash-map v0.5.3 (or a newer patch version) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit requires linked-hash-map to include contain-rs/linked-hash-map#100 When linked-hash-map is on v0.5.2, ttl_cache can panic due to the UB checks implemented in Rust 1.48: rust-lang/rust#66151
Owner
|
If a library consuming ttl_cache as is runs cargo update they will pick up the 0.5.3 version of linked-hash-map. If they aren't updating their dependencies then any change here won't help them anyways. Ultimately updating to the latest patch version of a dependency should be the responsibility of the final consumer of the library, and not intermediate libraries in the dependency graph. Tell every at ThreatX I said hi :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stusmall,
I found an issue with the linked_hash_map dependency on
<= v0.5.2. linked-hash-map can panic due to the UB checks implemented in Rust 1.48 (rust-lang/rust#66151, as it uses std::mem::uninitialized:v0.5.3 fixes the issue (contain-rs/linked-hash-map#100). This PR adds a requirement on v0.5.3 (or a newer patch version).