Open
Conversation
I manually edited lsp.json to add diagnostic message union string MarkupContent
rchl
reviewed
Apr 4, 2026
| class ColorPresentationResponse(TypedDict): | ||
| method: Literal['textDocument/colorPresentation'] | ||
| result: List['ColorPresentation'] | ||
| result: Union[List['ColorPresentation'], None] |
Member
There was a problem hiding this comment.
This doesn't seem to match https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#textDocument_colorPresentation and also it would be a breaking change.
EDIT: I suppose breaking changes like that are allowed in new spec versions. Technically those should already be guarded by capability.
Member
There was a problem hiding this comment.
Will assume that someone forgot to update the html version of the spec.
rchl
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings 3.18 LSP types.
I had the false impression that the latest changes to metaModel.json file are done at microsoft/vscode-languageserver-node, but actually the latest chnages are done at microsoft/language-server-protocol,
so I updated the download script to point to microsoft/language-server-protocol
I also manually edited lsp.json to add diagnostic message union string MarkupContent
until they fix it upstream.
As Janos noticed they have added the type in microsoft/language-server-protocol@df7c77b
and later removed it in microsoft/language-server-protocol@7e1b69d (I have asked them if this was a mistake)