feat: unify ANTLR setup and add pre_push make target #131
+81
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokoko
reviewed
Dec 13, 2025
tokoko
reviewed
Dec 13, 2025
| antlr: setup-antlr | ||
| cd third_party/substrait/grammar \ | ||
| && java -jar ${ANTLR_JAR} -o ../../../src/substrait/gen/antlr -Dlanguage=Python3 SubstraitType.g4 \ | ||
| && java -jar ../../../lib/antlr-complete.jar -o ../../../src/substrait/gen/antlr -Dlanguage=Python3 SubstraitType.g4 \ |
Contributor
There was a problem hiding this comment.
I'm not sure I understand why this hardcoded path will always work..
Contributor
Author
There was a problem hiding this comment.
The script is designed to download the ANTLR JAR file to that specific, project dir/lib. This approach is consistent with the relative path used for the ../../../src directory.
Contributor
|
@giospada this looks mergeable at the moment, but the thing is I'm thinking of changing the whole codegen setup to use pixi to avoid running the devcontainer in ci for codegen check. I checked and all the components we care about are available as conda packages (openjdk, libprotobuf, antlr, buf). I can merge this as-is before that happens if it's causing you any headache though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.