fix: change protoc version to v29.5 and protobuf to >=5 #141
Conversation
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
| - remote: buf.build/protocolbuffers/python:v29.5 | ||
| out: src | ||
| - remote: buf.build/community/nipunn1313-mypy:v4.0.0 | ||
| - remote: buf.build/community/nipunn1313-mypy:v3.7.0 |
There was a problem hiding this comment.
the mypy plugin says v4.0.0 has not been tested with older protoc versions than v32.0: https://github.com/nipunn1313/mypy-protobuf/tree/v4.0.0?tab=readme-ov-file#requirements-to-run-mypy-protobuf
| readme = "README.md" | ||
| requires-python = ">=3.10,<3.14" | ||
| dependencies = ["protobuf >=6.33,<7"] | ||
| dependencies = ["protobuf >=5,<7"] |
There was a problem hiding this comment.
in theory the upper bound could be even higher given this statement:
Python may break generated code compatibility in specific future major version releases, but it will be coupled with poison pill warnings and errors in advance. As of 6.32.0, all generated code since 3.20.0 will be supported until at least 8.x.y.
https://protobuf.dev/support/cross-version-runtime-guarantee/#python
2 participants
Generate code with protoc 29.5 which allows to run the code with
any version of the protobuf library that's newer than v5.x.