perf(reference_picker): implement incremental parsing#335
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets performance in the reference picker flow by switching reference_picker.parse_references() to an incremental, per-message cache and updating unit/replay fixtures accordingly. It also updates the reference struct fields (e.g., col instead of column) and adjusts picker collection logic to source references from the parse cache.
Changes:
- Implement incremental parsing + caching for code references keyed by
message_id. - Update reference struct fields and navigation behavior (including missing-file warnings).
- Update/replace unit tests and large replay expected JSON fixtures to match new output.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
lua/opencode/ui/reference_picker.lua |
Reworks parsing into an incremental cached scanner; updates picker collection + navigation. |
tests/unit/reference_picker_spec.lua |
Updates assertions and adds tests for caching/incremental behavior + picker collection from cache. |
tests/data/*.expected.json |
Refreshes replay fixture outputs (mostly formatting/serialization changes). |
.claude/settings.local.json |
Adds local Claude permissions configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address some performance issues in the rendering of large sessions