Skip to content

♿(frontend) use aria-haspopup menu on DropButton triggers#2126

Merged
Ovgodd merged 1 commit intomainfrom
fix/voice-over-rejected
Mar 27, 2026
Merged

♿(frontend) use aria-haspopup menu on DropButton triggers#2126
Ovgodd merged 1 commit intomainfrom
fix/voice-over-rejected

Conversation

@Ovgodd
Copy link
Copy Markdown
Collaborator

@Ovgodd Ovgodd commented Mar 25, 2026

Purpose

Fix incorrect VoiceOver announcements on menu triggers that use DropButton (document actions, language selector, and other dropdowns). The deprecated boolean aria-haspopup="true" led VoiceOver to read “rejected” instead of the expanded/collapsed menu state

Proposal

  • Set aria-haspopup="menu" on the DropButton trigger (matches the role="menu" content).
  • Update DropdownMenu unit test expectations for aria-haspopup.

@Ovgodd Ovgodd requested a review from AntoLC March 25, 2026 09:15
@Ovgodd Ovgodd self-assigned this Mar 25, 2026
@Ovgodd Ovgodd force-pushed the fix/voice-over-rejected branch from 32e83cc to 2b60f68 Compare March 25, 2026 09:15
@Ovgodd Ovgodd marked this pull request as ready for review March 25, 2026 09:15
@Ovgodd Ovgodd linked an issue Mar 25, 2026 that may be closed by this pull request
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Size Change: +2 B (0%)

Total Size: 4.25 MB

Filename Size Change
apps/impress/out/_next/static/2f55239b/_buildManifest.js 621 B +621 B (new file) 🆕
apps/impress/out/_next/static/4d604389/_buildManifest.js 0 B -621 B (removed) 🏆

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/voice-over-rejected branch from 2b60f68 to e9751f5 Compare March 27, 2026 10:23
Replace aria-haspopup true with menu on DropButton
@Ovgodd Ovgodd force-pushed the fix/voice-over-rejected branch from e9751f5 to 7f9869f Compare March 27, 2026 10:24
@Ovgodd Ovgodd merged commit 7f9869f into main Mar 27, 2026
27 of 28 checks passed
@Ovgodd Ovgodd deleted the fix/voice-over-rejected branch March 27, 2026 10:58
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Document action buttons: "rejected" state rendered incorrectly

2 participants