♻️ Move doc action buttons to fix toolbar#2360
Open
AntoLC wants to merge 5 commits into
Open
Conversation
Contributor
|
Size Change: +1.48 kB (+0.03%) Total Size: 4.32 MB 📦 View Changed
|
AntoLC
force-pushed
the
feat/comment-side-panel
branch
from
7d4748a to
e85e7d6
Compare
AntoLC
force-pushed
the
feat/floating-icons
branch
from
04224a1 to
65e44fc
Compare
Contributor
|
🚀 Preview will be available at https://2360-docs.ppr-docs.beta.numerique.gouv.fr/ You can use the existing account with these credentials:
You can also create a new account if you want to. Once this Pull Request is merged, the preview will be destroyed. |
AntoLC
force-pushed
the
feat/floating-icons
branch
5 times, most recently
from
ba34365 to
9e11739
Compare
We are modifying the doc header, we are moving elements to a floating bar. In this case, we are moving the Button Share to the floating bar.
We remove the AlertPublic component and replace it with a new visibility status in the DocHeaderInfo component. This change simplifies the user interface by providing a more direct indication of the document's visibility status, whether it's public or internal, without needing an additional alert component.
We are modifying the doc header, we are moving elements to a floating bar. In this case, we are moving the doc toolbox to the floating bar. We adapted the toolbox with the updated actions. We update the doc header to use all empty space. We moved the emoji part from the toolbox directly to the header.
Add wrapper to catch focus. Benefit: - The tooltip will show exactly in the middle of the title input text - When the user is click on the right side of the doc title, the title get the focus and the cursor, which is the expected behavior when editing a title.
The icon in the left panel header was updated to match the new design.
AntoLC
force-pushed
the
feat/floating-icons
branch
from
9e11739 to
15bcac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a doc is long, we need to scroll all the way up to get access to the sharing / download and ... menu.
We now moved all these action buttons to a fix toolbar.
Demo
Enregistrement.2026-05-28.171346.mp4