Conversation
csware
commented
Jul 3, 2016
- If a subfolder A of a site folder is named like a folder B in the root (/), then the folder B is taken instead of A.
- Fix endless recursion and make sure we stay in site.dest on Windows
On Windows parent_dir can be 'd:/' causing an endless recursion. Signed-off-by: Sven Strickroth <email@cs-ware.de>
If a subfolder A of a site folder is named like a folder B in the root (/), then the folder B is taken instead of A. Signed-off-by: Sven Strickroth <email@cs-ware.de>
|
The 2nd commit is unnecessary. Jekyll-paginate is not a dependency. Notices in lines 135/136 it does a |
|
I'm going to try and write some unit tests this weekend so I can test this against newer versions of Jekyll as they come out. I'll merge in your changes then. Thanks :) |
|
@sumdog If paginate is not there I'll get errors. |
|
@csware Interesting. What error are you seeing? |
|
Sorry it took so long. It's easy to test so I thought you test it yourself. Just remvoe the
Btw. I don't see any try-catch for paginate here: https://github.com/sumdog/jekyll-multisite/blob/master/lib/jekyll-multisite.rb#L136, it's always required. |
Fixes a regression introduced in commit 5b3dc16. Signed-off-by: Sven Strickroth <email@cs-ware.de>