Skip to content

fix(ext/node): tls upgrades for used sockets #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyannyacha merged 1 commit into from
Feb 9, 2026
Merged

fix(ext/node): tls upgrades for used sockets #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ext/node/polyfills/internal_binding/stream_wrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@
// TODO(petamoriken): enable prefer-primordials for node polyfills
// deno-lint-ignore-file prefer-primordials

import { core } from "ext:core/mod.js";
import { core, primordials } from "ext:core/mod.js";
const { internalRidSymbol } = core;
const {
PromiseResolve,
} = primordials;
import { op_can_write_vectored, op_raw_write_vectored } from "ext:core/ops";

import { TextEncoder } from "ext:deno_web/08_text_encoding.js";
Expand Down Expand Up @@ -319,6 +322,12 @@ export class LibuvStreamWrap extends HandleWrap {

/** Internal method for reading from the attached stream. */
async #read() {
// Queue the read operation and allow TLS upgrades to complete.
//
// This is done to ensure that the resource is not locked up by
// op_read.
await PromiseResolve();

let buf = this.#buf;

let nread: number | null;
Expand Down