cmake: use .so extension on Linux when building against older versions of SuperCollider#430
Open
dyfer wants to merge 1 commit into
Open
cmake: use .so extension on Linux when building against older versions of SuperCollider#430dyfer wants to merge 1 commit into
dyfer wants to merge 1 commit into
Conversation
when building against older versions of SuperCollider
dyfer
force-pushed
the
bring-back-old-extension
branch
from
71bff4a to
e08f5f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings back the .so extension on Linux/*nix when building sc3-plugins against SC 3.14 and lower (including the current stable branch). It will also default to .so on *nix if
SC_VERSIONcannot be found (e.g. in SC before version 3.11).SC_VERSIONis defined in SCVersion.txt in the SC sources.BTW I used the
SC_VERSIONvariable which clearly relates to SC, and not to the version of the plugins, regardless of what we decide in #429 in terms of versioning and usingPROJECT_VERSIONmoving forward.This change was previously discussed in #428 (comment)
Additionally, I removed the
PLUGIN_EXTENSIONvariable, as it doesn't seem to be used anywhere.