Skip to content

Fix smokescreen example url in smokescreen.html.erb#1075

Merged
andie787 merged 1 commit into
superfly:mainfrom
irreal:patch-1
Sep 28, 2023
Merged

Fix smokescreen example url in smokescreen.html.erb#1075
andie787 merged 1 commit into
superfly:mainfrom
irreal:patch-1

Conversation

@irreal
Copy link
Copy Markdown
Contributor

@irreal irreal commented Sep 28, 2023

Summary of changes

Update incorrect url to example repo for using Smokescreen

Related GitHub and Fly.io community links

n/a

Notes

n/a

@andie787
Copy link
Copy Markdown
Contributor

thanks!

@andie787 andie787 merged commit ac59dd4 into superfly:main Sep 28, 2023
@irreal
Copy link
Copy Markdown
Contributor Author

irreal commented Sep 28, 2023

Hi @andie787 , I'm not sure who maintains the actual Smokescreen example that I fixed the url to.
It was out of date and not working according to the Http Proxy spec. So I fixed it in two separate PRs: fly-apps/smokescreen#2 and fly-apps/smokescreen#3

It might be useful to get those merged in, and then you could even remove the outdated tag from this document, as I now brought the example up to date and verified everything is indeed working great. I'm using it in production right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants